]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
perf: Shut up another eslint error
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 29 Jun 2019 13:14:37 +0000 (15:14 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Tue, 23 Jul 2019 22:28:45 +0000 (00:28 +0200)
The functions here are asynchronous to handle control back to the
mainloop while waiting for an action to complete, not to run operations
in parallel. That is, the race condition the rule is protecting against
isn't an issue here, so disable the error.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627

js/perf/core.js
js/perf/hwtest.js

index 314d3ecf55f8727ba3becc185e620e47dbf50727..a2af0f9be9e22865d4bfc97cc69573c98e406a65 100644 (file)
@@ -126,9 +126,11 @@ function *run() {
 
     for (let i = 0; i < 2; i++) {
         Scripting.scriptEvent('applicationsShowStart');
+        // eslint-disable-next-line require-atomic-updates
         Main.overview._dash.showAppsButton.checked = true;
         yield Scripting.waitLeisure();
         Scripting.scriptEvent('applicationsShowDone');
+        // eslint-disable-next-line require-atomic-updates
         Main.overview._dash.showAppsButton.checked = false;
         yield Scripting.waitLeisure();
     }
index 9c3c620fd7f6e69b1a43349ca51649a85951adb0..fa24563233120e95e3e563eecb5cae8461ccedda 100644 (file)
@@ -126,6 +126,7 @@ function *run() {
     yield Scripting.sleep(1000);
 
     Scripting.scriptEvent('applicationsShowStart');
+    // eslint-disable-next-line require-atomic-updates
     Main.overview._dash.showAppsButton.checked = true;
 
     yield Scripting.waitLeisure();